Todd Lipcon has posted comments on this change. Change subject: rpc: improve behavior when GSSAPI SASL plugin is missing ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4908/1/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: Line 206: // If we can't initialize SASL, that indicates some kind of issue like > Wouldn't a missing plugin be caught in the pre-flight check? This should o oh... yea, I added the pre-flight check after I wrote this. Not sure if there are other cases where this matters, so maybe I'll just remove this part of the patch? -- To view, visit http://gerrit.cloudera.org:8080/4908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49b991fd7088666a2b8daad18d70844ed8a5451f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
