Mike Percy has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 10: (2 comments) Would you mind also adding a test that makes sure that attempting to copy over an existing (running) tablet, even in --force mode, fails? Also, I wonder what the value of the --force flag is, since this is a manual tool maybe we should always force. This seems like a tool that you would only typically use --force with, so why bother requiring people to specify it. http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: Line 1149 > it didn't look buggy after going through Restart/Start/Shutdown paths, it's It's bad that they have different semantics, because they implement the same interface. Anyway, I think we can live with this as-is, as long as the test passes on both Linux and macOS. Since I don't have a Mac, I'll assume you have gotten that part working. http://gerrit.cloudera.org:8080/#/c/4834/9/src/kudu/tools/tool_action_remote_replica.cc File src/kudu/tools/tool_action_remote_replica.cc: Line 331: strings::Substitute("Remote server returned error code $0", > Done, I am just curious how did we generate Code_Name from the proto file ? it's generated and placed in build/latest/src/kudu/tserver/tserver.pb.cc -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
