Sailesh Mukil has posted comments on this change. Change subject: rpc: move connection header send/receive into negotiation.cc ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4959/1//COMMIT_MSG Commit Message: PS1, Line 13: preparation for making SSL support negotiated : during connection establishment If this is the case, should the Send/ReceiveHeaderMessage() functions be called before InitSSL..() in this patch? Or would doing it later be fine? http://gerrit.cloudera.org:8080/#/c/4959/1/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: Line 75: const uint8_t buflen = kMagicNumberLength + kHeaderFlagsLength; DCHECK_EQ(conn->direction(), CLIENT) ? Line 83: TRACE("Waiting for connection header"); DCHECK(conn->direction(), SERVER) PS1, Line 228: RETURN_NOT_OK(conn->InitSaslServer()); I missed this in my patch, but I think it would be good to make both the SASL inits happen before the InitSSL..(). Just for readability purposes. Functionally I don't think it matters. -- To view, visit http://gerrit.cloudera.org:8080/4959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78a9b592b8cc139cc6db50cf9d0b48dc272d779a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
