Hello Dan Burkert, Sailesh Mukil, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4959
to review the following change.
Change subject: rpc: move connection header send/receive into negotiation.cc
......................................................................
rpc: move connection header send/receive into negotiation.cc
These methods were being called as part of the SASL negotiation code,
but really have nothing to do with SASL. This patch refactors them into
negotiation.cc.
This is some clean-up in preparation for making SSL support negotiated
during connection establishment ("StartTLS" style) rather than
pre-determined as on or off prior to creating the connection.
This doesn't affect the wire protocol at all: I verified this by
connecting to an existing cluster from a patched client.
Change-Id: I78a9b592b8cc139cc6db50cf9d0b48dc272d779a
---
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/sasl_helper.cc
M src/kudu/rpc/sasl_helper.h
M src/kudu/rpc/sasl_server.cc
M src/kudu/rpc/sasl_server.h
5 files changed, 24 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/4959/1
--
To view, visit http://gerrit.cloudera.org:8080/4959
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78a9b592b8cc139cc6db50cf9d0b48dc272d779a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
