Dan Burkert has posted comments on this change. Change subject: rpc: move connection header send/receive into negotiation.cc ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4959/1/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: PS1, Line 228: RETURN_NOT_OK(conn->InitSaslServer()); > I missed this in my patch, but I think it would be good to make both the SA I think we're planning to wrap TLS around SASL, so the current order makes sense from that perspective. -- To view, visit http://gerrit.cloudera.org:8080/4959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78a9b592b8cc139cc6db50cf9d0b48dc272d779a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
