Todd Lipcon has posted comments on this change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4983/1/src/kudu/tablet/diskrowset.h File src/kudu/tablet/diskrowset.h: Line 315: virtual Status NewRowIterator(const Schema *projection, > warning: function 'kudu::tablet::DiskRowSet::NewRowIterator' has a definiti Done http://gerrit.cloudera.org:8080/#/c/4983/1/src/kudu/tablet/major_delta_compaction-test.cc File src/kudu/tablet/major_delta_compaction-test.cc: Line 145: void VerifyDataWithMvccAndExpectedState(MvccSnapshot& snap, > warning: non-const reference parameter 'snap', make it const or use a point Done http://gerrit.cloudera.org:8080/#/c/4983/1/src/kudu/tablet/rowset.cc File src/kudu/tablet/rowset.cc: Line 79: } else { > warning: don't use else after return [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/4983/1/src/kudu/tablet/tablet-test-base.h File src/kudu/tablet/tablet-test-base.h: Line 422: boost::optional<TestRowVerifier> verifier) { > warning: the parameter 'verifier' is copied for each invocation but only us Done http://gerrit.cloudera.org:8080/#/c/4983/1/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: Line 492: bool TestSetupExpectsNulls(int32_t key_idx) { > warning: parameter 'key_idx' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/4983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d5c373e2d56039a3b8be272cb4fea3d5d840e5b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Anonymous Coward #80 Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
