Todd Lipcon has posted comments on this change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4983/3/src/kudu/tablet/tablet-test-base.h File src/kudu/tablet/tablet-test-base.h: Line 429: gscoped_ptr<RowwiseIterator> iter, > warning: the parameter 'iter' is copied for each invocation but only used a this is actually bogus, since the move ctor of gscoped_ptr has an intended "consume" side effect -- To view, visit http://gerrit.cloudera.org:8080/4983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d5c373e2d56039a3b8be272cb4fea3d5d840e5b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Anonymous Coward #80 Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
