Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Avoid extra fsyncs of tombstoned tablets during startup ......................................................................
Avoid extra fsyncs of tombstoned tablets during startup At startup, we roll-forward the deletion of any tombstoned tablets. This is often redundant if the tablet is already fully deleted (i.e. no blocks, no orphaned blocks, and no WAL). In that case, we can skip the expensive fsync to speed up startup. Before this patch, a server with a few thousand tombstoned tablets took ~6 minutes to start up (about ~100ms per tablet). After the patch, it only took 1 second. This patch also removes scary-looking 'WARNING' messages being printed for every tombstoned tablet at startup. Change-Id: I60cb184b8de2a6a381371ddcf2fb938a19757eec Reviewed-on: http://gerrit.cloudera.org:8080/4915 Tested-by: Kudu Jenkins Reviewed-by: Dinesh Bhat <[email protected]> Reviewed-by: Jean-Daniel Cryans <[email protected]> --- M src/kudu/consensus/consensus_meta.cc M src/kudu/consensus/log.cc M src/kudu/consensus/log.h M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc M src/kudu/integration-tests/external_mini_cluster_fs_inspector.h M src/kudu/tablet/tablet_metadata.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tserver/ts_tablet_manager.cc 9 files changed, 73 insertions(+), 10 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Dinesh Bhat: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60cb184b8de2a6a381371ddcf2fb938a19757eec Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
