Todd Lipcon has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: Line 173: return Status::OK(); > I wonder if we can narrow the 'skip-fsync' to tombstoned tablet bootstrap s OK, I reorganized the code a bit in the new revision of the patch: now we check whether the tombstoning is a 'no-op' at a higher level, with the plus that we no longer log a WARN message per tombstoned tablet during startup. Not entirely following what you mean by the bit about the superblock with no log -- that's only the case for a tombstoned tablet, right? What's the case you're talking about? We write the metadata to tombstoned before deleting the log/meta so I'm not sure how you could have a non-deleted metadata state with missing log. -- To view, visit http://gerrit.cloudera.org:8080/4915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60cb184b8de2a6a381371ddcf2fb938a19757eec Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
