Todd Lipcon has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: Line 173: return Status::OK(); > Perhaps I may be missing the entire picture here. Do we flush the tablet_da > Do we flush the tablet_data_state_ before we delete log/meta? Yes, TSTabletManager::DeleteTabletData() calls TabletMetadata::DeleteTabletData() (which flushes the state change) before it deletes the WALs. > It appeared like with your patch earlier we were skipping tablet_data_state_ > flush when a healthy but empty tablet was about to get tombstoned No, it was only skipping the flush if the metadata was _already_ in the 'tombstoned' state, not in the case that it was transitioning from a normal state to a deleted one. -- To view, visit http://gerrit.cloudera.org:8080/4915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60cb184b8de2a6a381371ddcf2fb938a19757eec Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
