Adar Dembo has posted comments on this change. Change subject: macOS: fix Kerberos tests where possible ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5005/1//COMMIT_MSG Commit Message: PS1, Line 7: where possible Can you elaborate on this in the rest of the commit message? What is the state of the Kerberos-tests-in-Kudu world following this patch? http://gerrit.cloudera.org:8080/#/c/5005/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: Line 262: CHECK_ERR(setenv("KRB5_KTNAME", kt_path.c_str(), 1 /*replace*/)); Won't setenv() leak into the run of other tests in the same file? If so, would you mind creating an RAII-style enabler/disabler for safe setenv() use? -- To view, visit http://gerrit.cloudera.org:8080/5005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I569a5c94b4aeba34b03690906fa1e356b55d9688 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
