Dan Burkert has posted comments on this change. Change subject: macOS: fix Kerberos tests where possible ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5005/3/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: PS3, Line 50: // Since we don't have any way to explicitly figure out the version, we just : // look for this random macro which was added in 1.11 (the same version in which : // the above bug was fixed). > If we end up doing more version-specific work for krb5, it would be best to This diff is the result of the rebase. -- To view, visit http://gerrit.cloudera.org:8080/5005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I569a5c94b4aeba34b03690906fa1e356b55d9688 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
