Adar Dembo has posted comments on this change. Change subject: macOS: fix Kerberos tests where possible ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5005/1//COMMIT_MSG Commit Message: PS1, Line 7: where possible > Can you elaborate on this in the rest of the commit message? What is the st I think you missed this. http://gerrit.cloudera.org:8080/#/c/5005/3/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: PS3, Line 50: public: : virtual void SetUp() OVERRIDE { : RpcTestBase::SetUp(); If we end up doing more version-specific work for krb5, it would be best to move this sort of thing into cmake. But, since this is the only such place right now, don't bother. -- To view, visit http://gerrit.cloudera.org:8080/5005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I569a5c94b4aeba34b03690906fa1e356b55d9688 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
