Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 15: (3 comments) Also updated COMMIT_MSG to reflect the new flag added. http://gerrit.cloudera.org:8080/#/c/4834/13/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: Line 80: DEFINE_bool(clean_unsafe, false, > Hmm, --force_unsafe, I guess I would prefer either --force or --clean_unsaf Done Line 81: "Delete the local replica completely, not leaving a tombstone. " > How about: Delete the local replica completely, not leaving a tombstone. Th Done Line 270: return Status::NotSupported(Substitute("Deletion of local replica $0 is " > s/not supported/currently not supported/ Done -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
