Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: Line 1149 > Are you saying that committing this patch will break the macOS build? Seems It doesn't fail the build, it fails the test on OS x only. Since my follow-up patch fixes it, I wouldn't see os x fix as a blocker to this, but I am fine submitting the os x fix first. http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: PS1, Line 276: return Status::OK(); : } > I am a bit torn on this one. Hmmm.... current notion is that we use 'local_replica delete' when we couldn't bring up tablet server due to one or more bad tablets. It makes sense to keep the bad tablet around with --archive option for debugging purposes later. At high level, I am still trying to think of a situation where we want to tombstone a bad tablet... today we bootstrap tombstoned tablet when we bring up the server right ? and chances are that we may still crash ? So, I am not sure how tombstoning would help here. I think one important piece as Todd pointed out in recovery doc is to be able to exactly identify which tablet is causing the crash. Otherwise, we wouldn't know what tablet this tool is supposed to act on. Having a tombstone option for a remote_replica (i.e, when destination tserver is running) may be useful. I will go down the path of last_logged id with 'remote_replica tombstone' may-be ? -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
