Mike Percy has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: PS1, Line 276: RETURN_NOT_OK(TSTabletManager::DeleteTabletData( : meta, TabletDataState::TABLET_DATA_DELETED, boost::none)); > Yeah sure, my first approach was to provide last_logged_opid, but I think t I am a bit torn on this one. On the one hand, I think tombstoning the replica by default would be much better, while also providing an option to delete it. Deletion is not generally safe and should only happen in an emergency scenario or when the table itself is being deleted. However, in order to properly tombstone a tablet, we should pass in the last_logged_opid. That comes from the WAL. I'm not sure how easy that is to do that without starting up lots of other components. I think it's worth attempting to get the last logged opid by spinning up a LogReader, and if it's actually not that difficult then we should do it. If it's very complicated then I suppose we can just rely on the remote replica tool for tombstoning and just use this one for local deletion. -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
