Adar Dembo has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5007/3/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: Line 224: TEST_F(FsManagerTestBase, TestTmpFilesCleanup) { Could you add something to the test file tree to exercise the checked_dirs logic? Maybe a self-referential symlink or something that would cause an infinite loop otherwise? http://gerrit.cloudera.org:8080/#/c/5007/3/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: Line 497: if (checked_dirs.find(canonized_path) == checked_dirs.end()) { Use ContainsKey() from gutil/map-util.h. -- To view, visit http://gerrit.cloudera.org:8080/5007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299e7b22c3f920430ff5d581cf7a507a83eb0101 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
