Maxim Smyatkin has posted comments on this change.

Change subject: KUDU-1634. TS and master should delete tmp metadata files on 
startup
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5007/3/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:

Line 224: TEST_F(FsManagerTestBase, TestTmpFilesCleanup) {
> Could you add something to the test file tree to exercise the checked_dirs 
Sure, I can. But how will Jenkins behave if it actually does loop forever? Will 
it stop it and report a failure?


-- 
To view, visit http://gerrit.cloudera.org:8080/5007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299e7b22c3f920430ff5d581cf7a507a83eb0101
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Maxim Smyatkin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Maxim Smyatkin <[email protected]>
Gerrit-HasComments: Yes

Reply via email to