Adar Dembo has posted comments on this change.

Change subject: KUDU-1634. TS and master should delete tmp metadata files on 
startup
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5007/4/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:

Line 268:   ASSERT_OK(CountTmpFiles(fs_manager()->env(), lookup_dirs, 
&checked_dirs, &n_tmp_files));
Seems like checked_dirs could be local to CountTmpFiles, and doesn't need to 
leak out into the test itself (since the test is only clearing it).


-- 
To view, visit http://gerrit.cloudera.org:8080/5007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299e7b22c3f920430ff5d581cf7a507a83eb0101
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Maxim Smyatkin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Maxim Smyatkin <[email protected]>
Gerrit-HasComments: Yes

Reply via email to