Todd Lipcon has posted comments on this change. Change subject: el6: fix krb5 realm workaround for static builds ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5100/1/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: PS1, Line 30: ${KRB5_REALM_OVERRIDE} : krb5) > If the ordering is critical (as I think it is, based on your commit descrip Done http://gerrit.cloudera.org:8080/#/c/5100/1/src/kudu/security/test/krb5_realm_override.cc File src/kudu/security/test/krb5_realm_override.cc: > We should move this out of the 'test' subdirectory so it's not confusing wh Done PS1, Line 32: The linkage invocation uses the '-Wl,--undefined' : // linker flag to force linking even though no symbol here is explicitly : // referenced. > Now that this is expected to be found in every Kudu binary, you could add a I tried that and couldn't quite get it to work without various link errors, etc. Already blew 3 hours trying to get the precise combination of jenga pieces here so I don't want to screw with it anymore. -- To view, visit http://gerrit.cloudera.org:8080/5100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I050d03d58658b650891566b9f955c867b15731e0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
