Todd Lipcon has posted comments on this change. Change subject: el6: fix krb5 realm workaround for static builds ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5100/4//COMMIT_MSG Commit Message: PS4, Line 32: important executables (tserver, master, and 'kudu' tool) > What about one-off executables like tpch, tpch_real_world, etc? And the cli yea, I'll rephrase this to say that it's the executables that are used by tests http://gerrit.cloudera.org:8080/#/c/5100/4/CMakeLists.txt File CMakeLists.txt: PS4, Line 945: Binaries which are used by tests need to link this in. > Can you update this to be very precise about what kind of binaries need it? Done Line 947: set(KRB5_REALM_OVERRIDE -Wl,--undefined=krb5_realm_override_loaded krb5_realm_override) > This line causes the macOS build to fail, but it appears if you wrap it in Done http://gerrit.cloudera.org:8080/#/c/5100/4/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 22: target_link_libraries(krb5_realm_override glog dl) > I don't think we want to link libdl on macOS. Done -- To view, visit http://gerrit.cloudera.org:8080/5100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I050d03d58658b650891566b9f955c867b15731e0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
