David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/local_tablet_writer.h File src/kudu/tablet/local_tablet_writer.h: PS3, Line 118: Since this a "local" tablet writer it shouldn't care about "safe" : // time, which is a distributed concept. > per my comment on the other commit, I'm a little nervous that there is some note that this patch series, so far, does not change the behavior of followers, just the behavior of leaders. Leaders used to move safe time on commit but now all replicas behave the same way and safe time is only adjusted on the TransactionManager. Interestingly we were advancing the safe time on the TransactionManager both for leaders and followers before the apply started which meant that even leader transactions would only advance the clean time and not the safe time on commit. So really this patch series doesn't introduce any change in behavior. -- To view, visit http://gerrit.cloudera.org:8080/5056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08be57ed5ab38e3980c85102971c5998f7da2dc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
