Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests ......................................................................
Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/5056/3//COMMIT_MSG Commit Message: PS3, Line 7: - nit: may be, remove those extra symbols? PS3, Line 19: interct typo http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/local_tablet_writer.h File src/kudu/tablet/local_tablet_writer.h: PS3, Line 82: vector<Op> ops; : ops.push_back(Op(type, &row)); nit: consider replacing with list-initializer style, i.e. remove the 'ops' variable at all and call WriteBatch like: WriteBatch({ Op(type, &row) }, result); PS3, Line 88: gscoped_ptr nit: consider using std::unique_ptr instead PS3, Line 104: NULL nit: consider using nullptr instead of NULL. PS3, Line 104: NULL nit: consider using nullptr instead of NULL. PS3, Line 151: TxResultPB result_; Is it needed at all after the change? PS3, Line 152: tserver::WriteRequestPB req_; Is it needed at all after the change? PS3, Line 153: gscoped_ptr<WriteTransactionState> tx_state_ Is this needed at all after the change? -- To view, visit http://gerrit.cloudera.org:8080/5056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08be57ed5ab38e3980c85102971c5998f7da2dc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
