Mike Percy has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/local_tablet_writer.h File src/kudu/tablet/local_tablet_writer.h: Line 96: CHECK_OK(SchemaToPB(*client_schema_, req.mutable_schema())); > hrm, we have some benchmarks based on LocalTabletWriter IIRC -- this might I didn't see anywhere that mt-tablet-test uses TxResultPB. In that case could keep result_ around and give last_op_result() thread-safe "last one wins" semantics. http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/tablet-test-base.h File src/kudu/tablet/tablet-test-base.h: Line 319: void InsertTestRows(LocalTabletWriter* writer, Why not make the writer a member of this base class? http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 372: DCHECK(!tx_state->has_timestamp()); might as well use a CHECK if this is only for tests -- To view, visit http://gerrit.cloudera.org:8080/5056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08be57ed5ab38e3980c85102971c5998f7da2dc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
