Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5200
Change subject: encodings: change IsBlockFull() to not take a limit parameter ...................................................................... encodings: change IsBlockFull() to not take a limit parameter Everywhere we called this, we used the same value (the configured cfile block size). Given that, it's simpler to not take the parameter. This makes it easier for an encoder to determine whether or not it is full in some other context, since it can safely assume that it knows the block size up front. Change-Id: I4598c1555732649eeebf43231082dd641ecfc576 --- M src/kudu/cfile/binary_dict_block.cc M src/kudu/cfile/binary_dict_block.h M src/kudu/cfile/binary_plain_block.cc M src/kudu/cfile/binary_plain_block.h M src/kudu/cfile/binary_prefix_block.cc M src/kudu/cfile/binary_prefix_block.h M src/kudu/cfile/block_encodings.h M src/kudu/cfile/bshuf_block.h M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/encoding-test.cc M src/kudu/cfile/gvint_block.cc M src/kudu/cfile/gvint_block.h M src/kudu/cfile/plain_bitmap_block.h M src/kudu/cfile/plain_block.h M src/kudu/cfile/rle_block.h M src/kudu/cfile/type_encodings.cc 16 files changed, 53 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5200/1 -- To view, visit http://gerrit.cloudera.org:8080/5200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4598c1555732649eeebf43231082dd641ecfc576 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]>
