Todd Lipcon has posted comments on this change. Change subject: encodings: change IsBlockFull() to not take a limit parameter ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5200/2/src/kudu/cfile/binary_plain_block.cc File src/kudu/cfile/binary_plain_block.cc: Line 86: // TODO: does it cost a lot to account these things specifically? > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/5200/2/src/kudu/cfile/binary_prefix_block.cc File src/kudu/cfile/binary_prefix_block.cc: Line 83: // TODO: take restarts size into account > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/5200/2/src/kudu/cfile/gvint_block.h File src/kudu/cfile/gvint_block.h: Line 52: int Add(const uint8_t *vals, size_t count) OVERRIDE; > warning: function 'kudu::cfile::GVIntBlockBuilder::Add' has a definition wi Done http://gerrit.cloudera.org:8080/#/c/5200/2/src/kudu/cfile/plain_bitmap_block.h File src/kudu/cfile/plain_bitmap_block.h: Line 52: return writer_.bytes_written() > options_->storage_attributes.cfile_block_size; > error: member access into incomplete type 'const kudu::cfile::WriterOptions Done http://gerrit.cloudera.org:8080/#/c/5200/2/src/kudu/cfile/rle_block.h File src/kudu/cfile/rle_block.h: Line 69: return encoder_.len() > options_->storage_attributes.cfile_block_size; > error: member access into incomplete type 'const kudu::cfile::WriterOptions Done -- To view, visit http://gerrit.cloudera.org:8080/5200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4598c1555732649eeebf43231082dd641ecfc576 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
