David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ......................................................................
Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/4995/14/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: PS14, Line 261: DCHECK(right.redo_head != nullptr); : const Mutation* right_last = left.redo_head; : AdvanceToLastInList(&right_last); no need to have the advance code twice with two different vars PS14, Line 671: live the most recent version might not be 'live' either. PS14, Line 688: se typo PS14, Line 1021: TODO(dralves) Make Reinserts set defaults on the dest row. point to the jira number PS14, Line 1093: versions remove reference to "versions" here and elsewhere -- To view, visit http://gerrit.cloudera.org:8080/4995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1173b2bea721b376f2b6049be20f57307582c47 Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
