Alexey Serbin has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest ......................................................................
Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: PS12, Line 347: CHECK_OK nit: In the context of this method and call sites, does it make sense to use ASSERT_OK() / RETURN_NOT_OK() paradigm instead of CHECK_OK()? Since that's an internal test utility, I would expect it to fail gracefully if an error happens. PS12, Line 533: std::greater<int>() I don't think using greater<> instead of default less<> brings any benefit here: internally, the std::unique call does the heavy-lifting via shifting the container elements, and that's done regardless of the sort order. -- To view, visit http://gerrit.cloudera.org:8080/4996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d15129e83c5c9afa9b643e674c8a23e18a2fa0e Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
