Alexey Serbin has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: PS12, Line 574: down_cast<kudu::server::LogicalClock*>( : tablet()->clock().get()) > we shouldn't use dynamic_cast on non-debug builds I don't mind using down_cast<> here, but what is the rational behind not using dynamic_cast in non-debug builds? As I can see, the down_cast<> is way more dangerous than dynamic_cast<> -- it's reduced just to static_cast<> in non-debug builds, which could lead to completely unpredictable results, way worse than a penalty of doing some RTTI-related calls. Also, this is just test code, so I wouldn't expect much of performance optimizations to be in place. -- To view, visit http://gerrit.cloudera.org:8080/4996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d15129e83c5c9afa9b643e674c8a23e18a2fa0e Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
