Alexey Serbin has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: PS12, Line 574: down_cast<kudu::server::LogicalClock*>( : tablet()->clock().get()) > thats a google style recommendation. we also build the clock inside the tes Ah, I see -- so it's a code style thing. The danger of the static_cast<> while doing downcasting: it does not allow to see that the operand could not be downcasted to the expected type. It's possible to end-up in a situation when the code executes some other methods, not what you expect. The comment for that down_cast<> method does not make any sense to me at all, since I don't understand how one can guarantee that all the paths which the code is about to execute are covered with the debug mode runs. So, I would either forbid any downcasting at all or allow it and make sure it's done with dynamic_cast<> only, so it's safe. -- To view, visit http://gerrit.cloudera.org:8080/4996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d15129e83c5c9afa9b643e674c8a23e18a2fa0e Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
