Todd Lipcon has submitted this change and it was merged. Change subject: Remove GROUP_VARINT encoding ......................................................................
Remove GROUP_VARINT encoding This encoding was only ever implemented for the UINT32 type, and users can no longer specify this type, since we only support signed ints. Thus, there's no sense carrying around this baggage. This patch removes the encoding as well as associated tests. Change-Id: I0b0aeb5bfd8451a6e190ccb6e55e971da668b062 Reviewed-on: http://gerrit.cloudera.org:8080/5271 Reviewed-by: Dan Burkert <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/cfile/CMakeLists.txt M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_writer.h M src/kudu/cfile/encoding-test.cc D src/kudu/cfile/gvint_block.cc D src/kudu/cfile/gvint_block.h M src/kudu/cfile/type_encodings.cc M src/kudu/client/schema.h M src/kudu/common/common.proto M src/kudu/tablet/diskrowset-test.cc 11 files changed, 14 insertions(+), 629 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b0aeb5bfd8451a6e190ccb6e55e971da668b062 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
