Todd Lipcon has posted comments on this change. Change subject: KUDU-1524. Add a workaround for unflushable large cells ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5282/1/src/kudu/cfile/block_compression.cc File src/kudu/cfile/block_compression.cc: Line 61: if (ub_compressed_size > FLAGS_max_cfile_block_size) { > why are you comparing the compressed size here in the write path, and teh u yea, it's a little goofy, but the idea is so that bad data doesn't cause us to do some crazy memory allocation or somesuch. A lot of this should probably be rethought as we work on improving stability of large cells, but figured I'd just keep the current behavior but make the limit configurable as a quick fix in case someone hits this issue again. -- To view, visit http://gerrit.cloudera.org:8080/5282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I245b52f2bc8b9d95716cacd340dca93f64846c73 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
