Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1524. Add a workaround for unflushable large cells ......................................................................
KUDU-1524. Add a workaround for unflushable large cells Previously, we had a hard-coded limit of 16MB for an individual cfile block. This would cause a CHECK failure if someone inserted a cell larger than this size. We should probably limit large cells in the write path in a separate patch, but it was also a bad idea to have this limit be a constant instead of an 'unsafe' flag. This switches to using a flag for the value so that, if we do end up in a situation like this, we can work around it by bumping the flag instead of recompiling. This also fixes the size limiting to be symmetric: we now always check the size of the *uncompressed* block, which ensures that if we're able to write a block, we will later be able to read it. Change-Id: I245b52f2bc8b9d95716cacd340dca93f64846c73 Reviewed-on: http://gerrit.cloudera.org:8080/5282 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/cfile/block_compression.cc M src/kudu/cfile/block_compression.h M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_writer.cc 4 files changed, 34 insertions(+), 27 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I245b52f2bc8b9d95716cacd340dca93f64846c73 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
