Todd Lipcon has posted comments on this change. Change subject: Patch for [KUDU-1422] ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5286/1/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java File java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java: PS1, Line 71: Mutator method for the private field maxCapacity should describe the observable effect, not the implementation Line 73: * @return whether or not maxCapacity was successfully set would be better to throw an exception on an illegal argument Line 75: public synchronized boolean setMaxCapacity(int maxCapacity) { the ErrorCollector class isn't a public API so adding this method doesn't make it usable by end-users. We need to also plumb this through somehow to public APIs. PS1, Line 76: if(maxCapacity > 0){ : this.maxCapacity = maxCapacity; : return true; : } : r nit: please conform to the style elsewhere in the file (no space after if, 2-space indentation) -- To view, visit http://gerrit.cloudera.org:8080/5286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73fd986d455433dd51fb447f85e114bacd58603a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: eric-maynard <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
