Todd Lipcon has posted comments on this change. Change subject: Patch for [KUDU-1422] ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5287/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: Line 207: this.errorCollector.setMaxCapacity(size); oh, now I see that you accidentally split it into two reviews. You should squash this into the other patch using a git rebase -i I also think that tying this to the mutation buffer space is a mistake, we should add a new public API. -- To view, visit http://gerrit.cloudera.org:8080/5287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia53793c0c8c420df9650b67f8a111b8606a4068c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: eric-maynard <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
