Adar Dembo has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ......................................................................
Patch Set 4: (3 comments) Just passing through and took an interest. If I'm understanding this correctly, the semantics of the StartTabletCopy RPC remain unchanged: remote callers will only receive a response when the copy is finished. Is that right? http://gerrit.cloudera.org:8080/#/c/5045/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS4, Line 383: nullptr Shouldn't need this; the constructor is guaranteed to set it. PS4, Line 532: cb = [](const Status&, TabletServerErrorPB::Code) { : LOG(FATAL) << "StartTabletCopy() callback invoked twice"; : }; Isn't 'cb' a local copy? How does this have an effect? PS4, Line 548: We run this asynchronously. No longer true. -- To view, visit http://gerrit.cloudera.org:8080/5045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c63f2bfd67624844447862efbdba9cb3676112 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
