Adar Dembo has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ......................................................................
Patch Set 6: > > If I'm understanding this correctly, the semantics of the > > StartTabletCopy RPC remain unchanged: remote callers will only > > receive a response when the copy is finished. Is that right? > > No: callers will receive a response once the process is started, > but will not be notified on completion. It would be good to add > APIs to get for status / completion, as well as enable > cancellation, but I think this is more important than those other > features. On second look I see what you mean; the moment we invoke the callback, we respond to the RPC. Why do this, though? Why not hold off responding until the very end of the tablet copy? Either way the copy is being performed on the new thread pool, so it shouldn't be a matter of resource usage, right? -- To view, visit http://gerrit.cloudera.org:8080/5045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c63f2bfd67624844447862efbdba9cb3676112 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
