Mike Percy has posted comments on this change.

Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async
......................................................................


Patch Set 6:

> > On second look I see what you mean; the moment we invoke the
 > > callback, we respond to the RPC.
 > >
 > > Why do this, though? Why not hold off responding until the very
 > end
 > > of the tablet copy? Either way the copy is being performed on the
 > > new thread pool, so it shouldn't be a matter of resource usage,
 > > right?
 > 
 > I'm going to take your advice and do this. I think it will also
 > solve the test failure issue.

OK I am going back and forth on this but I think it's better to return 
immediately because we get RPC timeouts otherwise, which clutter up the logs.

-- 
To view, visit http://gerrit.cloudera.org:8080/5045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95c63f2bfd67624844447862efbdba9cb3676112
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to