Todd Lipcon has posted comments on this change. Change subject: Add integration tests for duplicate keys ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5349/8/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: PS8, Line 991: // Ensure that the replicas converge. : // We don't know exactly how many rows got inserted, since the writer : // probably saw many errors which left inserts in indeterminate state. : // But, we should have at least as many as we got confirmation for. need to update this comment Line 1396: std::sort(results.begin(), results.end()); hrm, is this necessary? WaitForRowCount() uses ScanReplica() which has the same sort at the end, unless I'm missing something. -- To view, visit http://gerrit.cloudera.org:8080/5349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d018281d412ae034bd7b70c8311077a52b2795d Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
