Todd Lipcon has posted comments on this change. Change subject: Add integration tests for duplicate keys ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/5349/8/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 1396: std::sort(results.begin(), results.end()); > I saw a failure of this test where it showed the second row first. I assume OK, interesting. I did look this test 500 times when committing it, but not with stress threads. We'll watch the flaky dashboard for it. One plausible thing (just a guess) is that when we commit the new ops, they are still in-flight in the "apply" queue, and could get reordered if the upsert of key 2 happens faster than the upsert of key 1 (which had a prior version). So if we aren't using SCAN_AT_SNAPSHOT we might see an order inversion here unless we put the verification in a loop. -- To view, visit http://gerrit.cloudera.org:8080/5349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d018281d412ae034bd7b70c8311077a52b2795d Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
