Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS6, Line 949: StartTabletCopy > I wonder if multithreading this and running in parallel will make the proba I thought about it, but I looped this 300 times and it never failed so this seems to be sufficient. http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 412: #define CALLBACK_AND_RETURN(status) \ > Do we want to include error_code as a macro argument ? Otherwise, IMHO it's If we do that, we also need to include cb too. I just thought it looked messy. But if you feel strongly about it, I'll do it. PS6, Line 529: cb(Status::OK(), TabletServerErrorPB::UNKNOWN_ERROR) > Could we introduce a TabletServerErrorPB::OK to go along with such calls ? In the case of Status::OK(), the TabletServerErrorPB::Code is ignored in TabletServiceImpl, and ends up not being set in the response RPC. -- To view, visit http://gerrit.cloudera.org:8080/5045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c63f2bfd67624844447862efbdba9cb3676112 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
