Dan Burkert has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success ......................................................................
Patch Set 1: (3 comments) This one is a little over my head, since I didn't follow the discussion around it and didn't review the original patch, so I'm going to defer on giving a +2. If you want me to dig into it I can, though. http://gerrit.cloudera.org:8080/#/c/5399/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 598: "Found misaligned block in data file: $0\nRecord: $1", Maybe add a JIRA # as explanation for people who see this message? I would be pretty confused about what I should do as an operator given this warning. Line 755: "Container $0 unexpectedly tried to lower its size (from $1 to $2 " same here Line 1605: "Could not process record in container $o", container->ToString())); that looks like an o and not a 0? -- To view, visit http://gerrit.cloudera.org:8080/5399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49bc98c9f8b7dce0333f88cec85757fe122acfa4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
