Dan Burkert has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5399/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 755: "Container $0 unexpectedly tried to lower its size (from $1 to $2 " > This one is actually just defensive programming or future proofing, if for OK, makes sense then. Line 1689: LOG(WARNING) << "Skipping unknown op type in block record: " > The code as it was before prevents us from adding new record types and allo Yah, I guess it's a question of what we want to do in this situation - I thought it would be catastrophic to skip, but maybe that's not the case. There's a third option - we could warn and return a non-OK status. -- To view, visit http://gerrit.cloudera.org:8080/5399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49bc98c9f8b7dce0333f88cec85757fe122acfa4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
