Dan Burkert has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5399/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1689: LOG(WARNING) << "Skipping unknown op type in block record: " This could be a forwards compatibility hazard. Is there a strong reason not to fail here? -- To view, visit http://gerrit.cloudera.org:8080/5399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49bc98c9f8b7dce0333f88cec85757fe122acfa4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
