Anonymous Coward #265 has posted comments on this change. Change subject: csd: two minor changes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5435/1//COMMIT_MSG Commit Message: Line 23: So this probably makes the conversion a non-starter, right? You can't share (template) names between service-level and role-level parameters, so this won't work, unfortunately. You might be able to get them to work if you give them distinct names but the same config name. If you're lucky, you'll get "last one wins" semantics and the role-level one will appear last when both are set. You can then treat the role-level one as an override, with an empty default. You'd have to test that works though, and we should officially support that on the CM side if you want to go that route (ie add a unit test that does this). The safest thing to do, a method that I know will work, is to wait until Kudu is shipped with CM, then we can write some upgrade code to migrate your configs from service to role level. You could also keep this patch as-is (role-level only, no service-level) if you're willing to just release note that the old service-level values will be lost. Wouldn't be the wildest thing to release note for the first GA release. -- To view, visit http://gerrit.cloudera.org:8080/5435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74b2fcb69fde9e0dbb232dba78db53cc1543b489 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward #265 Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
