Adar Dembo has posted comments on this change. Change subject: csd: two minor changes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5435/1//COMMIT_MSG Commit Message: Line 23: So this probably makes the conversion a non-starter, right? > You can't share (template) names between service-level and role-level param I'm comfortable with losing old service-level values, but only if we're really "losing" them; the patch as-is causes them to be both inherited and unrevertable. If I change the parameter names, I think I get the desired behavior; the old value is lost, but the new parameters are isolated from one another as we wanted and seem to behave just fine. We'll just note that if you did override the service-level parameter, you'll lose the override in an upgrade. -- To view, visit http://gerrit.cloudera.org:8080/5435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74b2fcb69fde9e0dbb232dba78db53cc1543b489 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward #265 Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
