Jean-Daniel Cryans has submitted this change and it was merged. Change subject: csd: two minor changes ......................................................................
csd: two minor changes Revert the memory limit scaleFactor to the default value (1.0). 1.3 is recommended for Java processes; not sure why Kudu was using that. Convert the core dump directory to two separate role-level parameters. I relented and did this once I saw that Impala also defines its core dump directory in this way. In testing, the conversion was fine when the service-level parameter wasn't set. When it was set, I saw that the overridden value carried over to the roles even after the conversion (good!). However, attempting to remove the so-called "role" overrides in the UI yielded an error (bad!). To work around this, I changed the names of the parameters (i.e. I prepended either 'master' or 'tserver' to the names). This means any old value is lost during an upgrade to the new CSD (a little bad), but that's better than not being able to remove the value altogether. Change-Id: I74b2fcb69fde9e0dbb232dba78db53cc1543b489 Reviewed-on: http://gerrit.cloudera.org:8080/5435 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans <[email protected]> --- M java/kudu-csd/src/descriptor/service.sdl 1 file changed, 23 insertions(+), 15 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Anonymous Coward #265: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74b2fcb69fde9e0dbb232dba78db53cc1543b489 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward #265 Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins
