Will Berkeley has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/5167/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: PS3, Line 70: def getOperationType Could you move this into OperationType.scala and make it package-private (like the rest of OperationType)? PS3, Line 151: val fields: Array[StructField] = : table.getSchema.getColumns.asScala.map { kuduColumnToSparkField }.toArray This is dead code now http://gerrit.cloudera.org:8080/#/c/5167/3/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: PS3, Line 25: Please preserve this empty line. PS3, Line 31: import org.scalatest.{BeforeAndAfter, FunSuite, Matchers} Also the empty line here. We order the imports as java -> scala -> other imports -> kudu, with an empty line in between PS3, Line 33: import org.apache.spark.sql.types.{DataTypes, StructField, StructType}; This belongs in the block of other imports, sorted by import name. PS3, Line 377: dfWithUserSchema.limit(10).collect() Are you expecting the columns to be re-ordered in the rows? If so, could you verify that here in the test. -- To view, visit http://gerrit.cloudera.org:8080/5167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6073256b61a174f898be222058277be976273c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Manlove <[email protected]> Gerrit-Reviewer: Chris George <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
