Will Berkeley has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider ......................................................................
Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/5167/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: PS3, Line 70: case "update" > Could you move this into OperationType.scala and make it package-private (l Made it private. It makes sense to leave it here. Line 124: class KuduRelation(private val tableName: String, > update comments Done PS3, Line 151: userSchema match { : case Some(x) => > This is dead code now Done http://gerrit.cloudera.org:8080/#/c/5167/3/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: PS3, Line 25: > Please preserve this empty line. Done PS3, Line 31: import org.apache.spark.sql.types.{DataTypes, StructField > Also the empty line here. We order the imports as java -> scala -> other im Done PS3, Line 33: import org.junit.runner.RunWith > This belongs in the block of other imports, sorted by import name. Done PS3, Line 377: > Are you expecting the columns to be re-ordered in the rows? If so, could yo Done -- To view, visit http://gerrit.cloudera.org:8080/5167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6073256b61a174f898be222058277be976273c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Manlove <ajmanl...@gmail.com> Gerrit-Reviewer: Chris George <chris.geo...@rms.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
