Andrew Wong has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5167/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: PS5, Line 98: new KuduRelation(tableName, kuduMaster, operationType, Some(schema))(sqlContext) Should we add a check to see whether the schema is valid (e.g. non-unique columns that do exist in the original table)? -- To view, visit http://gerrit.cloudera.org:8080/5167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6073256b61a174f898be222058277be976273c Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Manlove <ajmanl...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Chris George <chris.geo...@rms.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
